Added mustAcceptTerms option for Sign up
#503
Conversation
Updated README
|
|
There was a problem hiding this comment.
I see you already have the setters for customizing the privacy policy and terms URL. Where are those links accessible from? I don't see the text above the sign up button having a link color, nor the new dialog (introduced in this PR) having buttons or links to them.
| @@ -244,6 +244,15 @@ class InputField: UIView, Stylable { | |||
| return 0 | |||
| } | |||
| } | |||
|
|
|||
| var isValid: Bool { | |||
| switch self { | |||
There was a problem hiding this comment.
is this normal? switching for a boolean seems way more complicated than just storing a "valid/!valid" boolean
There was a problem hiding this comment.
So by default you can't do that, unless you override and add comparisons for equality operators (which is annoying) as you need to specifically add for each case.
So in this case for clarity added this.
| @@ -121,6 +121,10 @@ class OptionsSpec: QuickSpec { | |||
| it("should have allowShowPassword enabled") { | |||
| expect(options.allowShowPassword) == true | |||
| } | |||
|
|
|||
| it("should have mustAcceptTerms disabled") { | |||
| expect(options.mustAcceptTerms) == false | |||
There was a problem hiding this comment.
is this test testing the "default value" ?
|
@lbalmaceda you can access those from the main screen at the bottom. |
where? this is not a link |
|
@lbalmaceda It may not look like it, but it is, agree it could look more obvious, it's always been like this though. |
Updated i18n Strings
Update README
Added Tests