Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default modal presentation style for iPad #493

Merged
merged 4 commits into from
Jan 29, 2018

Conversation

cocojoe
Copy link
Member

@cocojoe cocojoe commented Jan 25, 2018

Added Style option modalPopup for iPad, default true.
Fix #492
Updated Snapshot

@cocojoe cocojoe added this to the v2-Next milestone Jan 25, 2018
@cocojoe
Copy link
Member Author

cocojoe commented Jan 25, 2018

lock-fullscreen
lock-popup
passwordless

Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be considered breaking changing the default behavior on Ipads? Can the corners be less rounded, to match the web HLP design?

@cocojoe
Copy link
Member Author

cocojoe commented Jan 25, 2018

@lbalmaceda Honestly I consider this a fix to behaviour that was broken. However, I left in the option so you can disable the popup so it will use the old behaviour (just in case)

Regarding corners, yes I think I can adjust the layer to square up the corners.

@lbalmaceda
Copy link
Contributor

Please add this option setting somewhere in the readme and don't make the corners squared, but rather of a lower radius.

@cocojoe
Copy link
Member Author

cocojoe commented Jan 25, 2018

It's covered under style docs, which reference the style class as there are so many options. I can of course promote this one to the README.

@lbalmaceda
Copy link
Contributor

At least make sure that this """"behavior change"""" can be noticed in the CHANGELOG file. Add it manually after preparing the release if needed 👍

@lbalmaceda
Copy link
Contributor

See if you can make the X in the corner go up a bit to be at equal distance from the top and the right borders

@cocojoe
Copy link
Member Author

cocojoe commented Jan 26, 2018

simulator screen shot - ipad 5th generation - 2018-01-26 at 15 08 37
simulator screen shot - ipad 5th generation - 2018-01-26 at 15 08 34

@cocojoe cocojoe force-pushed the changed-ipad-use-modal branch from 05ab46d to 874a34e Compare January 29, 2018 15:37
@aaguiarz aaguiarz merged commit c3cb488 into master Jan 29, 2018
@cocojoe cocojoe deleted the changed-ipad-use-modal branch January 29, 2018 16:28
@cocojoe cocojoe mentioned this pull request Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants