-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed default modal presentation style for iPad #493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be considered breaking changing the default behavior on Ipads? Can the corners be less rounded, to match the web HLP design?
@lbalmaceda Honestly I consider this a fix to behaviour that was broken. However, I left in the option so you can disable the popup so it will use the old behaviour (just in case) Regarding corners, yes I think I can adjust the layer to square up the corners. |
Please add this option setting somewhere in the readme and don't make the corners squared, but rather of a lower radius. |
It's covered under style docs, which reference the style class as there are so many options. I can of course promote this one to the README. |
At least make sure that this """"behavior change"""" can be noticed in the CHANGELOG file. Add it manually after preparing the release if needed 👍 |
See if you can make the |
05ab46d
to
874a34e
Compare
Added Style option
modalPopup
for iPad, default true.Fix #492
Updated Snapshot