Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text replacement on return #460

Merged
merged 3 commits into from
Sep 11, 2017
Merged

Fix text replacement on return #460

merged 3 commits into from
Sep 11, 2017

Conversation

cocojoe
Copy link
Member

@cocojoe cocojoe commented Sep 8, 2017

Fix #427

@lbalmaceda lbalmaceda self-requested a review September 8, 2017 16:10
lbalmaceda
lbalmaceda reviewed Sep 8, 2017
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting it as a "extension" fixes it?

@cocojoe
Copy link
Member Author

cocojoe commented Sep 8, 2017 •
edited
Loading

No, I just moved it so it was clearer. The fix is self.onTextChange(self) on return.
I don't know what is going on with codecov, I remade the PR just to be sure as it says the no report found to compare happens if you forked from a commit that didn't pass all tests. However, it's forked from master which of course does.

@cocojoe
Copy link
Member Author

cocojoe commented Sep 8, 2017

Think I've got to the bottom of this now, the base comparison in codecov although it has been uploaded it's stuck in processing on codecov. I'll find that commit in CI and rebuild and hopefully that will flush it through. https://codecov.io/gh/auth0/Lock.swift/commit/a2d89fb9708515d3e68fed06000365ede75b0f28

@cocojoe cocojoe force-pushed the fix-text-replacement-on-return branch from 541ea9f to 6fc0c7b Compare September 8, 2017 20:36
@cocojoe cocojoe merged commit a07efbb into master Sep 11, 2017
@cocojoe cocojoe deleted the fix-text-replacement-on-return branch September 11, 2017 09:49
@cocojoe cocojoe added this to the v2-Next milestone Sep 15, 2017
@cocojoe cocojoe modified the milestones: v2-Next, 2.3.2 Sep 15, 2017
@cocojoe cocojoe mentioned this pull request Sep 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cocojoe @lbalmaceda