Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeAuth provider check and fallback in Auth0OAuth2Interactor #418

Merged
merged 4 commits into from
Apr 4, 2017

Conversation

cocojoe
Copy link
Member

@cocojoe cocojoe commented Mar 22, 2017

Update Tests, Mocks
Depends on auth0/Auth0.swift#104

@cocojoe cocojoe force-pushed the added-nativeauth-provider-check branch from 48d1327 to a351bb5 Compare March 27, 2017 11:20
Copy link
Member

@hzalaz hzalaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update with auth0.swift release

@@ -177,6 +177,23 @@ class Auth0OAuth2InteractorSpec: QuickSpec {
_ = authHandler.transaction.resume(DomainURL, options: [:])
}
}

context("disable provider") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a better context name

@hzalaz hzalaz added this to the v2-Next milestone Mar 28, 2017
@cocojoe cocojoe force-pushed the added-nativeauth-provider-check branch from a351bb5 to 4dab59d Compare March 28, 2017 09:03
@cocojoe cocojoe changed the title Added native auth availability check in Auth0OAuth2Interactor NativeAuth provider check and fallback in Auth0OAuth2Interactor Mar 28, 2017
@cocojoe cocojoe force-pushed the added-nativeauth-provider-check branch from 95ca7ae to 0971ab1 Compare April 4, 2017 10:47
@cocojoe cocojoe merged commit 1e6b269 into master Apr 4, 2017
@hzalaz hzalaz modified the milestones: v2-Next, 2.2.0 Apr 25, 2017
@hzalaz hzalaz deleted the added-nativeauth-provider-check branch May 8, 2017 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants