Added login_hint support to Enterprise Connections #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
force-pushed
the
feature_login_hint
branch
from
34ddd2a to
902cf8f
Compare
cocojoe
changed the title
hzalaz
suggested changes
Mar 16, 2017
Lock/Auth0OAuth2Interactor.swift
Outdated
| @@ -30,19 +30,22 @@ struct Auth0OAuth2Interactor: OAuth2Authenticatable { | |||
| let options: Options | |||
| let nativeHandlers: [String: AuthProvider] | |||
|
|
|||
| func login(_ connection: String, callback: @escaping (OAuth2AuthenticatableError?) -> Void) { | |||
| func login(_ connection: String, parameters: [String: String] = [:], callback: @escaping (OAuth2AuthenticatableError?) -> Void) { | |||
There was a problem hiding this comment.
Don't see the need now to add a dictionary of parameters that are already passed with Options. Now we only need to add an optional login_hint parameter so lets add just that
There was a problem hiding this comment.
Np, I was unsure if we should open it up for future use or just login_hint for now.
Lock/OAuth2Authenticatable.swift
Outdated
| func login(_ connection: String, parameters: [String: String], callback: @escaping (OAuth2AuthenticatableError?) -> Void) | ||
| } | ||
|
|
||
| extension OAuth2Authenticatable { |
There was a problem hiding this comment.
There is no need to have this one here since internally we'll always pass parameters
hzalaz
suggested changes
Mar 19, 2017
Lock/OAuth2Authenticatable.swift
Outdated
| func login(_ connection: String, loginHint: String?, callback: @escaping (OAuth2AuthenticatableError?) -> Void) | ||
| } | ||
|
|
||
| extension OAuth2Authenticatable { |
There was a problem hiding this comment.
There is no need to have this extension since Lock will always use the parameter
There was a problem hiding this comment.
I added it to default the OAuth2 button. However is less code just to pass nil :) Done
cocojoe
force-pushed
the
feature_login_hint
branch
from
673a2d2 to
26494e3
Compare
hzalaz
approved these changes
Mar 24, 2017
Added "login_hint" support to EnterpriseDomainInteractor Added Default Extension to OAuth2Authenticatable Added Tests Update Mocks
Updated Tests
Ensure loginHint param always specified Update Testing
Update auth0_shipper plugin
cocojoe
force-pushed
the
feature_login_hint
branch
from
f21b9cf to
e8b81d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.