Passwordless Email (Code/Link) and Social #395

cocojoe · 2017-02-16T11:44:28Z

Public API Methods:

Lock

static func continueAuth(using userActivity: NSUserActivity) -> Bool: Support NSUserActivity callbacks
func onPasswordless(callback: @escaping (String) -> Void) -> Lock : Be informed of passwordless auth initiated with identifier.
static func passwordless(): Lock passwordless instance loading Auth0 client info from Auth0.plist file in main bundle.
static func passwordless(clientId: String, domain: String) -> Lock: Lock passwordless instance using clientId and domain

New Options

passwordlessMethod: Specify to send a passcode .emailCode or universal link .emailLink

cocojoe · 2017-02-20T21:28:37Z

Notes:

Enabling Universal Links

AppDelegate

func application(_ application: UIApplication, continue userActivity: NSUserActivity, restorationHandler: @escaping ([Any]?) -> Void) -> Bool {
    return Lock.continueAuth(using: userActivity)
}

Setup

Enable the 'associated domains' in app capabilities
Add your auth0 domain applinks:{DOMAIN}
Check Auth0 Dashboard Select Client -> Advanced -> Mobile Settings App Bundle Identifier is set.

cocojoe · 2017-03-02T12:35:55Z

cocojoe · 2017-03-06T13:39:16Z

Although it will make the PR a little bigger, might make more sense to wait for SMS support as it has improvements and relies on this branch anyway as a base. So any change to this PR will need to be rebased anyway.

hzalaz · 2017-03-13T21:54:38Z

Lock/Lock.swift

+     */
+    public static func passwordless() -> Lock {
+        let newLock = Lock()
+        return newLock.withOptions { $0.passwordless = true }


Why don't we do this in the init?

hzalaz · 2017-03-13T21:55:14Z

Lock/Lock.swift

+
+     - returns: true if the link is of the appropriate format, false otherwise
+     */
+    public static func continueAuth(withActivity userActivity: NSUserActivity) -> Bool {


continueAuth(using userActivity: NSUserActivity) -> Bool

This is in next PR, will update in general public API bits.

hzalaz · 2017-03-13T21:55:59Z

Lock/LockOptions.swift

    var activeDirectoryEmailAsUsername: Bool = false
    var enterpriseConnectionUsingActiveAuth: [String] = []

    var oidcConformant: Bool = false
    var audience: String?
+
+    var passwordlessMethod: PasswordlessMethod = .code
+    var passwordless: Bool = false


either passwordlessOnly or classicMode to denote its one or the other

hzalaz · 2017-03-13T21:56:16Z

Lock/MultifactorCodeView.swift

        constraintEqual(anchor: center.topAnchor, toAnchor: self.topAnchor)
-        constraintEqual(anchor: center.rightAnchor, toAnchor: self.rightAnchor, constant: -20)


Where does the padding go? in the input?

This appears to have vanished after rebase.

what vanished? I can still see the change being done in this branch that removes the padding

Sorry, I miss interpreted you original comment. In the SingleInputView component, it wasn't as reusable (or compressible) as it could be so tidied the usage up in general. I checked the presenters that use it. MFA, ForgotPassword, EnterpriseDomain and Passwordless.

hzalaz · 2017-03-13T21:56:39Z

Lock/ObserverStore.swift

-    var onCancel: () -> Void = {  }
-    var onSignUp: (String, [String: Any]) -> Void = { _ in }
-    var onForgotPassword: (String) -> Void = { _ in }
+    var onAuth: (Credentials) -> () = { _ in }


Wasn't the change from () to Void part of the linter warnings?

Is old, ran a Lint pass.

hzalaz · 2017-03-13T22:01:14Z

Lock/PasswordlessActivity.swift

+
+import Foundation
+
+class PasswordlessActivity: PasswordlessUserActivity {


Why don't we follow the same style as the Auth tx where the handler has all the code and dependencies and we avoid retaining the messagePresenter

Agreed, think I tried this initially then had an issue so swapped to this to get running. If okay I'll address in another PR as internal.

cool we can do it in another PR

hzalaz · 2017-03-13T22:03:48Z

Lock/PasswordlessPresenter.swift

+    var messagePresenter: MessagePresenter?
+
+    var view: View {
+        switch self.screen {


I'd have made two presenters and distinct screens to avoid polluting them

This is a lot cleaner in followup PR

hzalaz · 2017-03-13T22:04:44Z

Lock/Router.swift

@@ -35,6 +35,7 @@ protocol Navigable {
    func resetScroll(_ animated: Bool)
    func scroll(toPosition: CGPoint, animated: Bool)

+    func onBack() -> ()


Why we have this one? I remember we had an event to go back

There is a method, however it's not in the protocol so inaccessible in the presenters.

hzalaz · 2017-03-13T22:05:17Z

Lock/Router.swift

@@ -35,6 +35,7 @@ protocol Navigable {
    func resetScroll(_ animated: Bool)
    func scroll(toPosition: CGPoint, animated: Bool)

+    func onBack() -> ()
 }

 struct Router: Navigable {


Shouldnt we have one router for classic and another for passwordless? The code seems more of a mess than it was previously

Possibly, it would be clearer in terms of internal separation, although it's 20 line block of code vs duplication of a lot more code. I don't really mind either way.

hzalaz · 2017-03-13T22:06:34Z

Lock/Lock.swift

+
+     - returns: Lock itself for chaining
+     */
+    public func onPasswordless(callback: @escaping (String, PasswordlessMethod) -> ()) -> Lock {


Why having the method here is useful? Also its missing docs on what the callback yields

It may or may not be useful, I look at it that a developer may want to know when they are sending out Email/SMS and hook into their own analytics. I'll update docs although I feel it should just be the identifier now.

hzalaz · 2017-03-15T22:28:27Z

Lock/ConnectionBuildable.swift

+
+     - parameter name:  name of the connection
+     */
+    mutating func passwordless(name: String)


how you will tell if its sms or email?

I didn't see any options in dashboard to create custom email/sms connections? (Like you can with OAuth2) So in Passwordless SMS it simply selects by name, unless I am missing something?

CDN

{ connections = ( { name = email; } ); name = email; }, { connections = ( { name = sms; } ); name = sms; }

You can create any connection with Auth0 API.

hzalaz · 2017-03-15T22:29:25Z

Lock/MultifactorCodeView.swift

        constraintEqual(anchor: center.topAnchor, toAnchor: self.topAnchor)
-        constraintEqual(anchor: center.rightAnchor, toAnchor: self.rightAnchor, constant: -20)


what vanished? I can still see the change being done in this branch that removes the padding

hzalaz · 2017-03-15T22:30:02Z

Lock/OptionBuildable.swift

 }

-internal extension OptionBuildable {
-    func validate() -> UnrecoverableError? {
+extension OptionBuildable {


why is not internal?

hzalaz · 2017-03-15T22:34:11Z

Lock/Passwordless.swift

+}
+
+public enum PasswordlessMethod: Int, Equatable {
+    case emailCode = 0


magicLink or code

I changed this inline with Lock.Android which has emailCode, emailLink, smsCode, smsLink. Passwordless SMS is based on this so backported it so no breaking public change.

Ok but lets only have magicLink and code in another PR

hzalaz · 2017-03-15T22:34:20Z

Lock/Passwordless.swift

+
+import Foundation
+
+enum PasswordlessScreen {


This is for?

This is for Passwordless routing, naming inspired by DatabaseScreen
Stage 1 .request. - Request a code/link
Stage 2a .code - Passcode Auth
Stage 2b .linkSent - Universal Link Confirmation

hzalaz · 2017-03-15T22:36:37Z

Lock/PasswordlessActivity.swift

+
+import Foundation
+
+class PasswordlessActivity: PasswordlessUserActivity {


cool we can do it in another PR

hzalaz · 2017-03-15T22:44:02Z

Lock/Router.swift

@@ -35,6 +35,7 @@ protocol Navigable {
    func resetScroll(_ animated: Bool)
    func scroll(toPosition: CGPoint, animated: Bool)

+    func onBack()


This probably was lost but why we added this?

It's not accessible by the presenters as it's not in the protocol, I used it as a convenience in the Passwordless presenter for routing back if code/link has not been delivered. There is no real reason an onBack() method shouldn't be in a Navigation protocol.

hzalaz · 2017-03-15T22:44:46Z

Lock/Router.swift

-                let presenter = DatabasePresenter(interactor: interactor, connection: database, navigator: self, options: self.lock.options)
-                if !oauth2.isEmpty {
+
+        if !self.lock.classicMode {


I still think this will be far cleaner using different routers to avoid the if-else nightmare. What are the parts that will be duplicated?

I'll add one and see how it looks.

Renamed activity callback to continueAuth(withActivity: Added support for Social Connections in Passwordless mode PasswordlessView UI Improvements Refactored usage of SingleInputView across views Updated README Update Tests

Rebase Fixes

Split Options Validation into Classic / Passwordless Update PasswordlessMethod Update Public API naming Added classic flag to Lock init Added Lock passwordless init onPasswordless only has identifier now Fix Force wrap Update Tests

Router Split into RouterClassic and RouterPasswordless Added Tests

hzalaz changed the base branch from v2 to master February 16, 2017 21:23

cocojoe force-pushed the feature_passwordless_email branch from 4d4ad09 to 7da20b3 Compare February 20, 2017 10:55

cocojoe force-pushed the feature_passwordless_email branch from 35abc97 to 203eb04 Compare February 20, 2017 21:29

cocojoe force-pushed the feature_passwordless_email branch from c85ded4 to 42dfb07 Compare March 6, 2017 10:07

cocojoe added the F3: in progress label Mar 6, 2017

cocojoe changed the title ~~Added Passwordless Email Code/MagicLink Support~~ Passwordless Email (Code/Link) and Social Mar 6, 2017

hzalaz suggested changes Mar 13, 2017

View reviewed changes

cocojoe force-pushed the feature_passwordless_email branch from 42dfb07 to 0d9b83e Compare March 14, 2017 11:04

cocojoe removed the F3: in progress label Mar 15, 2017

hzalaz suggested changes Mar 16, 2017

View reviewed changes

cocojoe and others added 12 commits March 19, 2017 17:28

Added Passwordless Email Support

9457fa8

Provision Fix

d5a4352

Added passwordless() mode to Lock

dbb8438

Renamed activity callback to continueAuth(withActivity: Added support for Social Connections in Passwordless mode PasswordlessView UI Improvements Refactored usage of SingleInputView across views Updated README Update Tests

Generate updated strings

784d07c

Fix i8n Strings

9c76042

Added Native Handlers Pass

d6dc493

SwiftLint Pass

370dd77

Rebase Fixes

Update Lock.Strings

276319c

Added Router Protocol, Router Factory

44d827a

Router Split into RouterClassic and RouterPasswordless Added Tests

Simplify Router protocol

c09ff19

Refactor Routers

e9159de

hzalaz force-pushed the feature_passwordless_email branch from 940d571 to e9159de Compare March 19, 2017 20:29

hzalaz approved these changes Mar 19, 2017

View reviewed changes

hzalaz merged commit 71a0403 into master Mar 19, 2017

hzalaz added the CH: Added label Mar 19, 2017

hzalaz added this to the v2-Next milestone Mar 19, 2017

hzalaz deleted the feature_passwordless_email branch April 6, 2017 23:39

hzalaz modified the milestones: v2-Next, 2.2.0 Apr 25, 2017

		constraintEqual(anchor: center.topAnchor, toAnchor: self.topAnchor)
		constraintEqual(anchor: center.rightAnchor, toAnchor: self.rightAnchor, constant: -20)


		import Foundation

		class PasswordlessActivity: PasswordlessUserActivity {

Passwordless Email (Code/Link) and Social #395

Passwordless Email (Code/Link) and Social #395

Conversation

cocojoe commented Feb 16, 2017 • edited Loading

Lock

cocojoe commented Feb 20, 2017 • edited Loading

AppDelegate

Setup

cocojoe commented Mar 2, 2017

cocojoe commented Mar 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cocojoe Mar 17, 2017 • edited Loading

Choose a reason for hiding this comment

CDN

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cocojoe Mar 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cocojoe Mar 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cocojoe commented Feb 16, 2017 •

edited

Loading

cocojoe commented Feb 20, 2017 •

edited

Loading

cocojoe Mar 17, 2017 •

edited

Loading

cocojoe Mar 17, 2017 •

edited

Loading

cocojoe Mar 17, 2017 •

edited

Loading