-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed release process to use maven publish plugin directly #739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! nice work @desusai7, I think we just have to make some changes to the release action as we have changed the number of variables we are passing in and the command to do the release has changed now - https://github.com/auth0/Auth0.Android/blob/main/.github/actions/maven-publish/action.yml#L39
Everything looks good to me
@poovamraj, updated the maven-publish action with new variables. Can you please take a look again ? |
Changes
maven-publish
plugin for publishing7.3.3
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist