Switch to non depcrated format for declaring new permissions #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seamuslee001
requested review from
Loreith,
andrew-cormick-dockery and
johntwyman
|
Does this change set a new minimum Civi version compatibility? My read of the core PR is that it doesn't, so we should be able to release this ASAP, right? |
johntwyman
approved these changes
Feb 13, 2024
|
@johntwyman I believe that is the case |
Loreith
approved these changes
Feb 13, 2024
andrew-cormick-dockery
approved these changes
Feb 13, 2024
|
This format has been supported for a long time in CiviCRM it was just never documented correctly. |
|
@johntwyman @andrew-cormick-dockery any issues with merging this MR? |
I'd like to update the changelog, after which I'll merge it. |
johntwyman
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to deal with this civicrm/civicrm-core#29173