Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for use_sti_base_class option #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

svoynow
Copy link

@svoynow svoynow commented Nov 28, 2014

This may be a very special case feature. But I don't think it clutters the code too much even if it is rarely used.
The idea is that if you're using STI, sometimes that's really an implementation detail and you don't want to have that reflected in your publicly facing IDs.
So if you pass this option, the generator use the row in the sequential table for the AR base class of the record.

@svoynow
Copy link
Author

svoynow commented Jan 8, 2015

The reason this is failing on CI is that it doesn't seem like the CI build is running new migrations. My test involves a new model and therefore a migration.
If the migration is run the tests do pass.
Given that, anything we can do to facilitate getting this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant