Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostStats@getDefaultFavicon returns an error #1300

Closed
1 task done
mho22 opened this issue Jun 16, 2023 · 0 comments
Closed
1 task done

PostStats@getDefaultFavicon returns an error #1300

mho22 opened this issue Jun 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@mho22
Copy link
Contributor

mho22 commented Jun 16, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

PostStats.vue Line 413

getDefaultFavicon(host) {
        return `https://favicons.githubusercontent.com/${host}`;
},

is not working anymore. The url returns this message :

Fastly error: unknown domain: favicons.githubusercontent.com. Please check that this domain has been added to a service.
@mho22 mho22 added the bug Something isn't working label Jun 16, 2023
austintoddj added a commit that referenced this issue Jun 22, 2023
@austintoddj
fixes deprecated Github favicons #1300
75edfa2
austintoddj added a commit that referenced this issue Jun 22, 2023
@austintoddj
uses an svg instead of an icon #1300
129c131
austintoddj added a commit that referenced this issue Jun 22, 2023
@austintoddj
Merge branch 'hotfix/6.0.47'
20c73b7 
* hotfix/6.0.47:
  builds assets
  Apply fixes from StyleCI (#1304)
  adds laravel mix and node scripts to fix #1181
  uses an svg instead of an icon #1300
  updates dependencies and compiles assets
  updates highlightjs version
  fixes deprecated Github favicons #1300
  Apply fixes from StyleCI (#1303)
  Corrected bug when CANVAS_PATH is empty in EmbedImageModal and FeaturedImageModal
austintoddj added a commit that referenced this issue Jun 22, 2023
@austintoddj
Merge tag 'v6.0.47' into develop
a7b4f35 
v6.0.47 stable release

* tag 'v6.0.47':
  builds assets
  Apply fixes from StyleCI (#1304)
  adds laravel mix and node scripts to fix #1181
  uses an svg instead of an icon #1300
  updates dependencies and compiles assets
  updates highlightjs version
  fixes deprecated Github favicons #1300
  Apply fixes from StyleCI (#1303)
  Corrected bug when CANVAS_PATH is empty in EmbedImageModal and FeaturedImageModal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@austintoddj @mho22