Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocorrect/autofill in server settings (#59) #60

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

andrewshadura
Copy link
Contributor

Prevent autocorrection on URLs, fix misspelled autoComplete property to enable username/password autofill on Android.

Without this the keyboard insists on inserting spaces and uppercasing HTTPS in the URL.

Completely untested as I have no idea how to build Subtracks.

@andrewshadura andrewshadura force-pushed the fix-autofill branch 2 times, most recently from 6da478e to 6a4ac87 Compare January 6, 2022 10:07
Copy link
Owner

@austinried austinried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I think the key thing here that you've fixed is that the URL field should probably have that autoCorrect=false bit to prevent those weird non-URL suggestions from showing up.

@andrewshadura
Copy link
Contributor Author

I’m curious though why password autofill doesn’t work with this setup.

@andrewshadura
Copy link
Contributor Author

Apparently importantForAutofill may be, well, important for autofill 🙂

@andrewshadura andrewshadura force-pushed the fix-autofill branch 2 times, most recently from dc0c535 to 3571ffc Compare January 11, 2022 12:50
Prevent autocorrection on URLs, disable autoCorrect and
autoCapitalise and set importantForAutofill.
@austinried
Copy link
Owner

I’m curious though why password autofill doesn’t work with this setup.

It actually does work for me already, I use bitwarden and I receive the autofill popup for that in both the username and password fields, along with the option for "Autofill" if I long press and hit the dots on that. What's your setup for this like?

@austinried
Copy link
Owner

Apparently importantForAutofill may be, well, important for autofill slightly_smiling_face

Ah I see, looks like the default of "auto" is probably what's providing the inconsistent results here.

Copy link
Owner

@austinried austinried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again!

@andrewshadura
Copy link
Contributor Author

It actually does work for me already, I use bitwarden and I receive the autofill popup for that in both the username and password fields, along with the option for "Autofill" if I long press and hit the dots on that. What's your setup for this like?

I use Firefox and usually it detects password fields in most apps. I’ll give it a go when this gets into F-Droid builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants