Skip to content
This repository has been archived by the owner on Apr 2, 2023. It is now read-only.

Http Offerset Plugin #80

Merged
merged 24 commits into from
Dec 27, 2020
Merged

Http Offerset Plugin #80

merged 24 commits into from
Dec 27, 2020

Conversation

lenhattan86
Copy link
Collaborator

Description:

The plugin sends the request and offer list to a plugin running on the same node with aurora.
It receives the response (sorted offers) from the plugin, and proceeds the task assignment process.

Testing Done:

  • Performance & Scalability tests
  • Failover test.
  • Plugin failure test.

Copy link
Contributor

@ridv ridv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to format the Java code in the same style as the rest of the project.

@mauri
Copy link
Contributor

mauri commented Oct 15, 2020

Is this PR on the right repo? why is the package com.paypal.aurora?

@ridv
Copy link
Contributor

ridv commented Oct 16, 2020

Hey @mauri, glad to see you're still around 😄 . We'll probably change the packaging name but we're upstreaming an offer sorting module that's able to use an external program with a defined interface to sort offers. The reason this is an HTTP interface is because we wanted to be able to use a program written in a different language to do this (we wrote ours in Go).

We may maintain this sorter in a different repo but we figured we'd try to upstream it first.

@ridv ridv changed the title Paypal plugin MagicMatch Offerset plugin Oct 16, 2020
Copy link
Contributor

@ridv ridv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we migrate the package from src/main/java/com/paypal/aurora... to src/main/java/io/github/aurora-scheduler/...?

Also we could use some documentation for the HTTP endpoints MagicMatch uses. That way someone else can come in and replace MagicMatch with something of their own.

In fact, we could rename this OfferSet module to be called something like HttpOfferSet at this point. @zorro786 and @lenhattan86 any thoughts?

@lenhattan86
Copy link
Collaborator Author

@ridv @zorro786 Can you guys take another pass?

Copy link
Contributor

@ridv ridv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good job @lenhattan86 this PR has come a long way from the initial version.

Copy link
Contributor

@ridv ridv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's switch to using the Apache HTTP client and I think we're ready to ship!

Copy link
Contributor

@ridv ridv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Great job @lenhattan86

Copy link
Collaborator

@zorro786 zorro786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you fix these, LGTM.

Copy link
Collaborator

@zorro786 zorro786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ridv ridv merged commit 68aa92a into aurora-scheduler:master Dec 27, 2020
@ridv ridv added this to the 0.24.0 milestone Jan 5, 2021
@ridv ridv changed the title MagicMatch Offerset plugin Http Offerset plugin Jan 5, 2021
@ridv ridv changed the title Http Offerset plugin Http Offerset Plugin Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants