This repository has been archived by the owner on Apr 2, 2023. It is now read-only.
Fix duplicate host issue for aurora scheduler, DTCPIOPS-5221 #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenhattan86
suggested changes
Jun 6, 2022
There was a problem hiding this comment.
- at line 260 of HttpOfferSetImpl, can we change
catch (IOException e)tocatch (Exception e)so that we wont be worry if something wrong happens and caused aurora-scheduler stuck in a scheduling cycle. - can we address this issue track the number of offers filtered out by scheduler plugins #401 in this PR too? if badOffers are filtered out in line 227 of HttpOfferSetImpl, we should keep track this number too.
src/main/java/io/github/aurora/scheduler/offers/HttpOfferSetImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/aurora/scheduler/offers/HttpOfferSetImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/aurora/scheduler/offers/HttpOfferSetImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/aurora/scheduler/offers/HttpOfferSetImpl.java
Outdated
Show resolved
Hide resolved
lenhattan86
suggested changes
Jun 6, 2022
src/main/java/io/github/aurora/scheduler/offers/HttpOfferSetImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/aurora/scheduler/offers/HttpOfferSetImpl.java
Outdated
Show resolved
Hide resolved
lenhattan86
approved these changes
Jun 11, 2022
This was referenced Jun 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes duplicate host issue for aurora scheduler.
Re-write the code to fix the issue, and still keep O(n) in processing response for efficiency to scale.
Testing Done:
Set up a local cluster by cloning repo: https://github.com/lenhattan86/aurora-docker
Instructions in https://engineering.paypalcorp.com/confluence/pages/viewpage.action?spaceKey=GE&title=Aurora+scheduler+development+environment+and+test+setup, section Setup Aurora Scheduler testing environment.
Change magicmatch/docker-compose.yml to have offers with 2 duplicate hostname to test the issue.