Prevent integer division with raw numerics #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes a loophole and makes the library more consistent.
chiphogg
added
the
release notes: 🐛 lib (bugfix)
There are a _lot_ of instances of this in the AV repo, mostly in embedded code. As I worked through updating them, I realized that replacing these instances with `integer_quotient()` was making the code worse. I think what we're really worried about here is mixing integer division with unit conversions. This overload is the only one that doesn't change the units. We'll still provide `integer_quotient()` for this case just for completeness, though.
I was running the wrong test.
geoffviola
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes a loophole and makes the library more consistent.
Fixes #39.