Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: fix Berlin hard fork test and transactions validation #45

Merged
merged 12 commits into from
Jun 11, 2024

Conversation

mrLSD
Copy link
Member

@mrLSD mrLSD commented Jun 6, 2024

Description

Berlin hard fork fails with transactions validations for EIP-1559, that was introduced in London hard work, that followed right after Berlin.

▶️ Fixed transactions validations for EIP-1559
▶️ Rafactored vicinity transactions validation
▶️ Recaftored TR_TypeNotSupported errors

🔐 Now every initial state validation check validation correctness with expected_error_message to ensure that validation fail is expected behavior.

@mrLSD mrLSD added the tests label Jun 6, 2024
@mrLSD mrLSD self-assigned this Jun 6, 2024
@mrLSD mrLSD marked this pull request as ready for review June 7, 2024 10:49
@mrLSD mrLSD requested review from aleksuss and birchmd June 7, 2024 10:56
evm-tests/jsontests/src/state.rs Outdated Show resolved Hide resolved
evm-tests/jsontests/src/state.rs Outdated Show resolved Hide resolved
aleksuss
aleksuss previously approved these changes Jun 7, 2024
birchmd
birchmd previously approved these changes Jun 7, 2024
Copy link
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@mrLSD mrLSD changed the base branch from feat/fix-london to master June 11, 2024 13:40
@mrLSD mrLSD dismissed stale reviews from birchmd and aleksuss June 11, 2024 13:40

The base branch was changed.

@mrLSD mrLSD requested a review from aleksuss June 11, 2024 15:22
@mrLSD mrLSD merged commit 58f7b84 into master Jun 11, 2024
4 checks passed
@mrLSD mrLSD deleted the feat/fix-berlin branch June 11, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants