Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid 'BUFFER_OVERRUN' error for unsupported revert reason. Resolves #165 #171

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

spilin
Copy link
Collaborator

@spilin spilin commented Jan 21, 2022

On some reverts reason can not be decoded. Thus let's avoid raising BUFFER_OVERRUN which is not informative.

@spilin spilin requested a review from 0x3bfc as a code owner January 21, 2022 14:10
@spilin spilin linked an issue Jan 21, 2022 that may be closed by this pull request
@spilin spilin requested review from artob and mfornet January 21, 2022 14:11
Copy link
Contributor

@mfornet mfornet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge for better error messages

@end0cr1ne
Copy link

Hi, @artob and @0x3bfc could you please take a look and approve? This would help to debug issues immensely!

@mfornet mfornet merged commit 2ada767 into master Jan 24, 2022
@mfornet mfornet deleted the buffer_overrun branch January 24, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUFFER_OVERRUN Error on mainnet
3 participants