Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store route thresholds in local and remote #438

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Siraj-Aizlewood
Copy link
Contributor

@Siraj-Aizlewood Siraj-Aizlewood commented Oct 1, 2024

User description

Particularly remote, so that different users can sync thresholds with one another.


PR Type

enhancement


Description

  • Added a TODO comment in the add method of pinecone.py to consider including thresholds in the metadata. This suggests future enhancement for storing Route thresholds in the metadata, potentially aiding in synchronization across different users.

Changes walkthrough 📝

Relevant files
Enhancement
pinecone.py
Add TODO for threshold inclusion in metadata                         

semantic_router/index/pinecone.py

  • Added a TODO comment to consider including threshold in metadata.
+1/-0     

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

@Siraj-Aizlewood Siraj-Aizlewood self-assigned this Oct 1, 2024
@github-actions github-actions bot added the enhancement Enhancement to existing features label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Future Enhancement
The TODO comment suggests adding threshold data to metadata, which could be a significant enhancement for user synchronization. This should be planned and implemented carefully to ensure data integrity and system performance.

Copy link

github-actions bot commented Oct 1, 2024

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.01%. Comparing base (b2dcb6d) to head (abd8ec4).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
+ Coverage   67.78%   68.01%   +0.23%     
==========================================
  Files          46       46              
  Lines        3501     3489      -12     
==========================================
  Hits         2373     2373              
+ Misses       1128     1116      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescalam jamescalam changed the title feat: Need to be able to store Route thresholds both in local and remote indexes feat: store Route thresholds in local and remote Oct 11, 2024
@jamescalam jamescalam changed the title feat: store Route thresholds in local and remote feat: store route thresholds in local and remote Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing features Review effort [1-5]: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants