Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in deprecation warning #283

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: typo in deprecation warning #283

merged 1 commit into from
May 15, 2024

Conversation

jamescalam
Copy link
Member

@jamescalam jamescalam commented May 15, 2024

PR Type

enhancement


Description

  • Updated the URL in the deprecation warnings across multiple files to reflect the new location of the semantic-chunkers package.
  • The changes ensure that users are directed to the correct repository aurelio-labs/semantic-chunkers for further information.

Changes walkthrough 📝

Relevant files
Enhancement
consecutive_sim.py
Update Repository URL in Deprecation Warning                         

semantic_router/splitters/consecutive_sim.py

  • Updated the URL in the deprecation warning to point to the new
    repository aurelio-labs/semantic-chunkers.
  • +1/-1     
    cumulative_sim.py
    Update Repository URL in Deprecation Warning                         

    semantic_router/splitters/cumulative_sim.py

  • Updated the URL in the deprecation warning to point to the new
    repository aurelio-labs/semantic-chunkers.
  • +1/-1     
    rolling_window.py
    Update Repository URL in Deprecation Warning                         

    semantic_router/splitters/rolling_window.py

  • Updated the URL in the deprecation warning to point to the new
    repository aurelio-labs/semantic-chunkers.
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @jamescalam jamescalam merged commit 8fb8cd0 into main May 15, 2024
    6 checks passed
    @jamescalam jamescalam deleted the james/deprecation-type branch May 15, 2024 04:10
    @github-actions github-actions bot added the enhancement Enhancement to existing features label May 15, 2024
    Copy link

    PR Description updated to latest commit (fe6d0c0)

    Copy link

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    1, because the PR involves simple URL updates in deprecation warnings across a few files. The changes are straightforward and do not involve complex logic or extensive modifications.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    No

    🔒 Security concerns

    No

    Code feedback:

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    enhancement Enhancement to existing features Review effort [1-5]: 1
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant