feat: QdrantIndex #207
Merged
feat: QdrantIndex #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 78.00% 78.20% +0.19%
==========================================
Files 42 43 +1
Lines 2146 2234 +88
==========================================
+ Hits 1674 1747 +73
- Misses 472 487 +15 ☔ View full report in Codecov by Sentry. |
jamescalam
requested changes
Mar 18, 2024
There was a problem hiding this comment.
hi @Anush008 thanks for the PR this is great! I have a few comments, could we fix those and then we should be good to run tests and merge all being okay, thanks!
mesax1
approved these changes
Mar 19, 2024
jamescalam
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Qdrant to be used as a supported index in Semantic Router.
Testing
The integration tests have been configured to run using an in-memory Qdrant instance if
qdrant-clientis installed. Skipped otherwise.