Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes #188 AzureOpenAIEncoder issue #189

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

szelesaron
Copy link
Contributor

@szelesaron szelesaron commented Mar 6, 2024

Added missing .self to class init.

Fixes Issue #188

@jamescalam jamescalam self-assigned this Mar 7, 2024
@jamescalam jamescalam self-requested a review March 7, 2024 07:50
@jamescalam jamescalam added the bug Something isn't working label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.73%. Comparing base (cbae899) to head (31d78a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   77.73%   77.73%           
=======================================
  Files          42       42           
  Lines        2084     2084           
=======================================
  Hits         1620     1620           
  Misses        464      464           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescalam
Copy link
Member

jamescalam commented Mar 7, 2024

@szelesaron thanks for the PR — could you fix the linting issues? We have instructions in contributor guidelines (number 5), ie:

  1. Ensure that All Pull Request Checks Pass There are Pull Request checks that need to be satifisfied before the changes can be merged. These appear towards the bottom of the Pull Request webpage on GitHub, and include:
  • Ensure that the Pull Request title is prepended with a valid type. E.g. feat: My New Feature.
    • Run linting (and fix any issues that are flagged) by:
    • Navigating to /semantic-router.
    • Running make lint to fix linting issues.
    • Running black . to fix black linting issues.
    • Running ruff . --fix to fix ruff linting issues (where possible, others may need manual changes).
    • Running mypy . and then fixing any of the issues that are raised.
    • Confirming the linters pass using make lint again.

Thanks!

@jamescalam jamescalam changed the title fixes #188 AzureOpenAIEncoder issue fix: fixes #188 AzureOpenAIEncoder issue Mar 7, 2024
@szelesaron
Copy link
Contributor Author

@jamescalam thanks for your fast reply. The linting issue is resolved.

@szelesaron szelesaron requested a review from jamescalam March 8, 2024 07:09
@jamescalam jamescalam merged commit 0cd4c37 into aurelio-labs:main Mar 8, 2024
8 checks passed
@jamescalam
Copy link
Member

merged, thanks @szelesaron!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants