Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CLIP for multi modal #155

Merged
merged 28 commits into from
Mar 2, 2024
Merged

feat: add CLIP for multi modal #155

merged 28 commits into from
Mar 2, 2024

Conversation

jamescalam
Copy link
Member

No description provided.

@jamescalam jamescalam changed the title James/clip feat: add CLIP for multi modal Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 90.09901% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 77.73%. Comparing base (c87fff1) to head (691684e).

Files Patch % Lines
semantic_router/encoders/clip.py 93.90% 5 Missing ⚠️
semantic_router/encoders/vit.py 72.22% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   77.08%   77.73%   +0.65%     
==========================================
  Files          41       42       +1     
  Lines        1994     2084      +90     
==========================================
+ Hits         1537     1620      +83     
- Misses        457      464       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Siraj-Aizlewood Siraj-Aizlewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments.

@jamescalam jamescalam merged commit 5612572 into main Mar 2, 2024
8 checks passed
@jamescalam jamescalam deleted the james/clip branch March 2, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants