Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds VitEncoder for visual transformers #129

Merged
merged 8 commits into from
Feb 19, 2024
Merged

Conversation

bruvduroiu
Copy link
Member

@bruvduroiu bruvduroiu commented Jan 30, 2024

TODO:

  • formalise Pydantic types for routes
  • more unit tests that cover torch
  • documentation

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (544a6ba) 83.82% compared to head (797544c) 84.30%.

Files Patch % Lines
semantic_router/encoders/vit.py 98.24% 1 Missing ⚠️
semantic_router/index/local.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   83.82%   84.30%   +0.48%     
==========================================
  Files          35       36       +1     
  Lines        1632     1695      +63     
==========================================
+ Hits         1368     1429      +61     
- Misses        264      266       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bruvduroiu bruvduroiu changed the title WIP: Adds VitEncoder for visual transformers Adds VitEncoder for visual transformers Feb 19, 2024
@jamescalam jamescalam changed the title Adds VitEncoder for visual transformers feat: Adds VitEncoder for visual transformers Feb 19, 2024
@jamescalam jamescalam merged commit 8b4e60b into main Feb 19, 2024
8 checks passed
@jamescalam jamescalam deleted the bogdan/vit-encoder branch February 19, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants