Homework 2019 11 19 #284
Open
Homework 2019 11 19 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… access if one's admin
| - { property: 'roles', type: 'collection' } | ||
| - { property: 'plainPassword', type: 'password' } | ||
| - { property: 'homepage', type: 'url' } | ||
| entities: |
There was a problem hiding this comment.
Verta atskirti kodo stiliaus pakeitimus ir funkcionalumo pakeitimą
Plačiau:
| @@ -0,0 +1,31 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Nepalikinėk šiukšlių. Ši migracija nieko nedaro
There was a problem hiding this comment.
Kodas veikia ➕ buvo atskira pasakita (gal ir be namų darbų) apie Doctrine ➕ vėlai atrašau (jau greitai final atsiskaitymas) – tai už namų darbus balo nemažinu – palieku tavo sąžinei, ar verta pasigilinti
| @@ -12,5 +12,10 @@ | |||
| <div class="mb-2"> | |||
| <span class="badge badge-primary">Website</span> <a href="{{ user.homepage }}"></a>{{ user.homepage }} | |||
| </div> | |||
| {% if user.linkedin is not null %} | |||
| <div class="mb-2"> | |||
| <span class="badge badge-primary">LinkedIn</span> <a href="{{ user.linkedin }}"></a>{{ user.linkedin }} | |||
There was a problem hiding this comment.
Suggested change
| <span class="badge badge-primary">LinkedIn</span> <a href="{{ user.linkedin }}"></a>{{ user.linkedin }} | |
| <span class="badge badge-primary">LinkedIn</span> <a href="{{ user.linkedin }}">{{ user.linkedin }}</a> |
Gal tuo ir skiriasi programuotojai nuo testuotojų... vieni mato kodą, kiti veikiantį kodą
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Andrius Simanaitis