-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register dependency serializers #205
Merged
Merged
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3dc7bee
Register dependency serializers
elitastic a1ce419
revert formatting changes
elitastic 411272a
refresh dist files
elitastic d2ab72f
app-filesystem-cache test added
elitastic 23a47fe
refactor: add typings to serialization context
bigopon f6b6b4b
fix(pnpm): ensure peer deps
bigopon a309764
fix(ci): use link-parent-bin
bigopon 9b0270a
fix(ci): pnpm peer deps
bigopon d6b07af
fix(ci): use hoist for pnpm, move link parent bin to config
bigopon c4c5d6f
fix(ci): tweak link parent bin script
bigopon 5525c44
fix(tests): tweak install script app test
bigopon d8b0107
fix(tests): pin pnpm to v6
bigopon 4e0e059
chore(tests): try fix pnpm test again
bigopon 906e25a
serialize preserveModuleName on NormalModule
elitastic bc14049
fix plugin when cache not set
elitastic 5657c74
fix: pnpm test ci config
bigopon c41ce6c
chore: add karma test for file cache
bigopon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
export class ClassSerializer<T extends ISerializable> { | ||
constructor(private ctor: { new(...params: any[]): T }) { | ||
} | ||
|
||
serialize(obj: T, context: any) { | ||
obj.serialize(context); | ||
} | ||
|
||
deserialize(context: any) { | ||
const obj = new this.ctor(); | ||
obj.deserialize(context); | ||
return obj; | ||
} | ||
} | ||
|
||
interface ISerializable { | ||
serialize(context: any): void; | ||
deserialize(context: any): void | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know the type of this context? if we do, I'd prefer that we have it here instead of any
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's
ObjectSerializerContext
. Unfortunately, this type is only listed but not exported in the webpack ts definition file if I see this correctly.