-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fixes #153
Build fixes #153
Conversation
… to custom_typings
I'll re-check this and make any necessary changes after #147 has been merged - if these changes are still necessary for a working build, that is |
The |
From lerna doc, lerna bootstrap --hoist can give better performance, just in case it was a pain for you |
well since you mentioned --hoist .. there is explicit support for lerna in yarn workspaces.. as well as ability to specifically --noihoist something |
@bigopon Thanks for the tip, it did indeed took ages.. :) |
@bigopon I did not. I'm not that deep into aurelia development process. Can you share what drawbacks you forsee? |
@Alexander-Taran Any minor change in the way dependencies are resolved, even if they are objectively improvements, could result in a different build output and potentially breaking changes for apps running in production. You never know for sure, it would need to be checked (hence significant work involved). Is probably something that needs to go in a next major release for the sake of safety. |
As of right now, builds should all be working already. |
Yep they do, nice. Your call whether you still want to merge this PR. It still builds with the master merges. Would allow the current I'd like to know whether you will or not though, so I know from which commit to proceed with the test setups if you want to go forward with those. |
Been looking over this for a bit, going to not merge this one in. However I did merge in the testing changes. |
This PR should completely fix the build and possibly some other problems which existed before, such as ux-components not fully working.
Steps (i used) to verify:
git clone https://github.com/fkleuver/ux.git fkleuver-ux
cd fkleuver-ux
git checkout build-fixes
npm install
.\node_modules\.bin\lerna bootstrap
(I had to run this 3 times in a row before everything was done, this is due to a Windows-specific issue with lerna).\node_modules\.bin\lerna run build
And everything looks all green and happy again
Now, I'm a tad hesitant about the
custom_typings
approach I took but it seems like the least hacky solution. Those missing types simply don't exist inaurelia-binding.d.ts
all the way up to 1.6.0, only just recently @bigopon added them to the master branch there. I doubtaurelia-ux
will be updating the dependencies that high up anytime soon.tsc
also kept choking on the existing workaroundux-core/src/extension.ts
- these.d.ts
files I added are a replacement for that to fix the typing errors without affecting the build outputs. If you see a better way with less duplication and without overly hacky cross-references, I'd love to go with that instead. This is the best I could come up with for now.