Adds PLATFORM.modulename to internationalization module loading #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears Aurelia cannot load "aurelia-i18n" plugin (in all configurations) without using the PLATFORM.modulename utility. This was the case with WebPack at least. This also adds an example configuration in TypeScript.
|
aurelia/framework#858 (comment) is related. I wonder if this means the documentation and examples should be rephrased to remove mentions of |
|
Yeah so I hope that PR gets merged and we all can get rid of PLATFORM.modulename. Your PR would incline that this change is needed for all bundlers/loaders but immo its only necessary for webpack. So maybe you could just modify it slighty, hinting that this change is needed only for Webpack and might be obsolete in future. Good catch though, for newcomers it seems this is something quite a lot people stumble upon |
|
@zewa666 Check that. I'll reword. |
|
thanks for the PRs @veikkoeeva and @atsu85 for the review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears Aurelia cannot load "aurelia-i18n" plugin (in all configurations)
without using the PLATFORM.modulename utility. This was the case with WebPack
at least. This also adds an example configuration in TypeScript.