fix(parser): left-to-right associativity for nested binary expression… #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with same precedence
|
Thanks @fkleuver. You are really quick! I think this should be released quickly since it is a big regression (and it caused me some headaches). |
|
Agreed. Binary parsing received the biggest rework and I only tested precedence, not associativity. My sincere apologies! Going to beef up the test coverage in the integration of parsing + evaluation a lot more in the coming days and make sure that everything is covered (and that it can't happen again) |
|
Thanks a lot. And really you don't need to apologize. I could have done the same. I'm just concerned about others that might be struggling right now to understand why their shiny component is broken :-). I've added parens on my side and everything is fine again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow I missed this one. Big oops. Fixes #586 (comment)
@EisenbergEffect