Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): merge lexer with parser & optimize parser #679

Merged
merged 18 commits into from
May 5, 2018
Merged

refactor(parser): merge lexer with parser & optimize parser #679

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
199e150
refactor(parser): merge lexer with parser & optimize parser
fkleuver Apr 20, 2018
b91a0e2
refactor(value-converter): set AllArgs inside constructor
fkleuver Apr 24, 2018
c60e240
test(parser): cleanup / add more tests
fkleuver Apr 24, 2018
384aeee
fix(parser): make unicode escape case insensitive
fkleuver Apr 24, 2018
4d0c97d
fix(parser): check bounds for unicode escapes
fkleuver Apr 24, 2018
d7fb6d5
tests(parser): add unit tests for binary expression precedence
fkleuver Apr 24, 2018
8048949
tests(parser): add unit tests for parsing numbers
fkleuver Apr 24, 2018
54c85b3
docs(parser): add documentation link for operator precedence
fkleuver Apr 24, 2018
01beaf3
refactor(parser): optimize number scanning
fkleuver Apr 24, 2018
eec9b10
refactor(parser): clean-up, improve readability
fkleuver Apr 26, 2018
61033c2
refactor(parser): align token names with char names
fkleuver Apr 26, 2018
e5ea180
docs(parser): fix typo
fkleuver Apr 27, 2018
59f34e8
refactor(parser): minor tweak to currentChar
fkleuver Apr 27, 2018
fdbb497
chore(parser): fix formatting
fkleuver Apr 28, 2018
bb185e3
refactor(parser): improve decimal parsing
fkleuver Apr 28, 2018
2ffeb84
refactor(parser): improve/test error reporting
fkleuver Apr 29, 2018
d31ee61
fix(parser): ensure property accessors are identifiers, make invalid …
fkleuver Apr 29, 2018
1e2270f
tests(parser): remove duplicate tests, fix error verification, correc…
fkleuver May 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,13 @@ export class BindingBehavior extends Expression {
}

export class ValueConverter extends Expression {
constructor(expression, name, args, allArgs) {
constructor(expression, name, args) {
super();

this.expression = expression;
this.name = name;
this.args = args;
this.allArgs = allArgs;
this.allArgs = [expression].concat(args);
}

evaluate(scope, lookupFunctions) {
Expand Down
Loading