chore(router-lite): allowed dot in parameter value #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dot character was reserved, presumably to support action component syntax. However, we currently don't have a roadmap to support that feature, the dot character is allowed in the path in this commit.
Sayan751
force-pushed
the
topic/2049-router-lite-dot-in-path
branch
from
1d258f7 to
1a26157
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2057 +/- ##
==========================================
+ Coverage 88.93% 88.95% +0.01%
==========================================
Files 279 279
Lines 23142 23164 +22
Branches 5339 5342 +3
==========================================
+ Hits 20581 20605 +24
+ Misses 2561 2559 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
cc: @ivanbacher |
bigopon
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
The dot character was reserved, presumably to support action component syntax. However, we currently don't have a roadmap to support that feature, the dot character is allowed in the path in this commit.
if a character is considered terminal, maybe having 2 of it could mean action, if we ever need that.
Nice work @Sayan751
AureliaEffect
pushed a commit
that referenced
this pull request
Sep 30, 2024
2.0.0-beta.22 (2024-09-30) **BREAKING CHANGES:** * **ast:** correct null/undefined handling (#2055) ([b96d7c4](b96d7c4)) the default non-strict mode now behaves like optional syntax: property access on null/undefined will return undefined null/undefined function calls will return undefined. The rest will behave like standard JS, including strict mode * **observers:** change callback timing to after notify (#2039) ([1e587e1](1e587e1)) bindable callback will be called with the timing as "after all have settled", instead of "right when new value comes" * **parser:** no longer provide default to exp parser interface (#2024) ([b55cbcd](b55cbcd)) In build time compilation, template expressions are parsed at build time, we don't need to bundle the expression parser code again. This cleanup is to prepare for that. * **ast:** separate & allow binding behavior and value converter evaluation to be optional (#2058) ([7d7e21b](7d7e21b)) Try simplify the interface of ast evaluator so that evaluating ast doesn't always require value converter/binding behavior to be supported. This is useful in scenarios where we dont need those two: watch/effect/computed/validation message etc... **Features:** * **observation:** ability to watch an expression (#2059) ([6cd6b8d](6cd6b8d)) * **runtime-html:** reuse host and hostController (#2043) ([0fe216e](0fe216e)) * **bindable:** support aggregated callback (#2033) ([7cdf3f0](7cdf3f0)) **Bug Fixes:** * **router-lite:** allowed dot in parameter value (#2057) ([9337c84](9337c84)) * **watch:** initialise only once (#2056) ([7ae2cfa](7ae2cfa)) * **router:** fix refresh with url params issue (#2051) ([6b733b1](6b733b1)) * **repeat:** fix update issues when there are duplicates ([9834c40](9834c40)) * **router:** fix redirect to async raise cond issue (#2046) ([c5dfca3](c5dfca3)) * **router-lite:** element injection issue (#2045) ([4d93507](4d93507)) * **validation-i18n:** prioritization of translated messages (#2029) ([a5340f8](a5340f8)) * **radio:** handle repeated start/stop correctly (#2031) ([430b8f0](430b8f0)) * **validation-html:** reset binding while unbinding BB (#2027) ([a3b1d09](a3b1d09)) **Docs:** * **vite-plugin:** add vite instruction for tailwindcss-integration.md (#2028) ([47913c5](47913c5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
The dot character was reserved, presumably to support action component syntax. However, we currently don't have a roadmap to support that feature, the dot character is allowed in the path in this commit.
🎫 Issues
Closes #2049.
👩💻 Reviewer Notes
📑 Test Plan
⏭ Next Steps