Removed Lexer() from template-gatherer due to aurelia-binding 2.0.0 #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aurelia-binding 2.0.0 included PR #679 that significantly updated the Parsing subsystem. In doing so, the submitter merged the Lexer() functions into the Parser() functions, so this library needs it's reference to Lexer in the
template-gathererVM to be addressed.This PR removes the Lexer() function and replaces it with a straight Parser() function. In updating to aurelia-binding 2.0.0, you'll find this required many other packages to be also updated. I've attempted to validate as much as possible that everything works in the Demo App and all built in tests have passed to this point.