[BUG] Fix bad use of strripos #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is 100% valid for strripos to return 0 we want quotes in that case for the AS blah NEVER EVER if a strripos, always explicitly check for false!! This was breaking jsonb text returns with mixed case aliases Select "pt"."name"->>'en_US' AS "myDescription" from mytable pt is what we want to end up with The replaceNamesAndAliasIn was getting ' AS myDescription' and not properly escaping it because the strripos was returning 0
|
Hey @auroraeosrose , Thank you for the PR. Can I add you to one of the maintainers. So you can also merge and release soon. I didn't find this earlier or missed for some reason. So don't want PR to wait so long. |
|
@koriym I guess I made a mistake. We never released 4.x . So merging to 4.x was something I did wrong. I guess it should go to 3.x. |
|
Should probably go to both if the issue exists in both branches |
|
I have pushed to 3.x, 2.x . 4.x seems not released yet. Bug fixes are released in 2.8.1 and 3.0.0 . Thank you. |
|
@harikt Yes. The 3.x test covers PHP 5.6 through PHP 8.2. （We don't need the 4.x branch now, right?） |
|
Cool. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is 100% valid for strripos to return 0 and still be considered a match
we want quotes in that case for the AS blah
NEVER EVER if a strripos, always explicitly check for false!!
This was breaking jsonb text returns with mixed case aliases
Select "pt"."name"->>'en_US' AS "myDescription" from mytable pt is what we want to end up with
The replaceNamesAndAliasIn was getting ' AS myDescription' and not properly escaping it because the strripos was returning 0