Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join and From conflict #90

Closed
metalfox6383 opened this issue Apr 25, 2016 · 5 comments
Closed

Join and From conflict #90

metalfox6383 opened this issue Apr 25, 2016 · 5 comments

Comments

@metalfox6383
Copy link

Hello:
I'm building my sentence. I can't use "join" function before "from" function. When I tried, my app give me thist error: "Cannot join() without from() first." Line 453 of \src\Common\Select.php

Your description says I can use the functions with any order. I check your file and I guess you must use other array for "join" part.

I like this lib, is very usefull. Thanks.

@pmjones
Copy link
Member

pmjones commented Apr 25, 2016

Ah yes, we need to either (1) correct the documentation, or (2) figure out a way to subordinate JOINs added before a FROM to the first FROM added after that.

@metalfox6383
Copy link
Author

Great! Please, take option 2. Thanks and greetings.

pmjones pushed a commit that referenced this issue May 19, 2016
…t from. if no from is ever added, the joins will never be built into the statement. refs #69, #90.
@pmjones
Copy link
Member

pmjones commented May 19, 2016

@metalfox6383 Please review PR #96 , which is an attempt at fixing this issue.

@pmjones
Copy link
Member

pmjones commented May 20, 2016

Fixed by #96; please review and open a new issue if it does not work the way you'd like. Thanks!

@pmjones pmjones closed this as completed May 20, 2016
@metalfox6383
Copy link
Author

Thanks. I will check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants