Add establishConnection() for interoperability with future versions #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update the docs also ? Thank you. |
|
I would think adding to the upgrade notes about the change, and update the getting started section, sound about right. Also would it be a good idea to backport this to 3.x and above versions or just keep it to 5.x? We also would need to update 6.x docs aswell with the new |
|
I have update the docs, but please any other suggestions to the docs would be welcome. |
harikt
reviewed
Nov 22, 2024
| @@ -1,3 +1,44 @@ | |||
| # 5.x Upgrade Notes | |||
There was a problem hiding this comment.
No I meen 5.x as it is a deprecation in 5.x and adding a alias for connect() method, as the commit is targeting 5.x branch.
I need to make PR for the doc changes in 6.x which explain the new connect method.
harikt
reviewed
Nov 22, 2024
harikt
reviewed
Nov 22, 2024
harikt
reviewed
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows eaiser switch between v5 and v4 of Aura.Sql and different PHP versions