Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix split_part macro #50

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix split_part macro #50

merged 1 commit into from
Mar 5, 2024

Conversation

nielspardon
Copy link
Contributor

Fixes #49

  • Replaces the existing implementation with a functioning one using a combination of REGEXP_SUBSTR and REGEXP_COUNT, the new implementation also escapes any characters in the delimiter_text which would be regex special characters e.g. | is being used in the test data as a split delimiter
  • Replaces the copy of the test seed data with a reference to the upstream test seed data
  • Updates the poetry.lock file

@nielspardon
Fix split_part macro
0291775 
Signed-off-by: Niels Pardon <[email protected]>
This was referenced Mar 4, 2024
Merged
Merged
Merged
aurany
aurany approved these changes Mar 5, 2024
View reviewed changes
Copy link
Owner

@aurany aurany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aurany aurany merged commit d0cb567 into aurany:master Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurany aurany aurany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

split_part macro implementation is broken
2 participants
@nielspardon @aurany