Skip to content

Commit

Permalink
Restrict Vm Operating System detection for XP
Browse files Browse the repository at this point in the history
A code for setting Operating System on a Vm uses name parsing
as a fallback. There was too much generic pattern "xp" which
could mark linux Vm name including "xp" as Windows XP machines,
which was incorrect and confusing for users.

Removing "xp" from Operating System patterns.

Related to https://bugzilla.redhat.com/show_bug.cgi?id=1576076
  • Loading branch information
aufi committed May 10, 2018
1 parent 85b25a1 commit cd4e6dd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/models/operating_system.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class OperatingSystem < ApplicationRecord

@@os_map = [
["windows_generic", %w(winnetenterprise w2k3 win2k3 server2003 winnetstandard servernt)],
["windows_generic", %w(winxppro winxp xp)],
["windows_generic", %w(winxppro winxp)],
["windows_generic", %w(vista longhorn)],
["windows_generic", %w(win2k win2000)],
["windows_generic", %w(microsoft windows winnt)],
Expand Down

0 comments on commit cd4e6dd

Please sign in to comment.