Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ci to GitHub actions #707 #734

Conversation

FrancisBilla
Copy link
Contributor

@FrancisBilla FrancisBilla commented Apr 6, 2024

Resolve issue #707

Copy link
Collaborator

@pydanny pydanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! A few requests:

  1. Remove appveyor.yml
  2. Remove coverage
  3. Switch to pytest or make test command

run: |
python -m pip install --upgrade pip
pip install coverage
if [ -f requirements.txt ]; then pip install -r requirements_dev.txt; fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ -f requirements.txt ]; then pip install -r requirements_dev.txt; fi
if [ -f requirements.txt ]; then pip install -r requirements_dev.txt; else pip install . fi

.github/workflows/build-pipeline.yml Outdated Show resolved Hide resolved
@audreyfeldroy audreyfeldroy merged commit 77e60ef into audreyfeldroy:master Apr 6, 2024
@audreyfeldroy
Copy link
Owner

Awesome work, thanks @FrancisBilla !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants