Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Artifactory backend under Python 3.12 #259

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jan 22, 2025

With release 1.0.0 of dohq-artifactory they fixed support for Python 3.12, so we can now support it here as well.

I also updated the installation instructions accordingly:

image

Summary by Sourcery

Build:

  • Update the project dependencies to require dohq-artifactory >=1.0.0 and support Python 3.12.

Copy link
Contributor

sourcery-ai bot commented Jan 22, 2025

Reviewer's Guide by Sourcery

The pull request updates the dohq-artifactory dependency to version 1.0.0 and adjusts the supported Python versions to include up to 3.12.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the dohq-artifactory dependency and adjusted the supported Python versions.
  • Updated the dohq-artifactory dependency to version 1.0.0.
  • Adjusted the supported Python versions to include up to 3.12.
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

@hagenw hagenw force-pushed the artifactory-update branch from 4bbc544 to cf8653c Compare January 23, 2025 12:21
@hagenw hagenw changed the title Depend on dohq-artifactory >=1.0.0 Support Artifactory backend under Python 3.12 Jan 23, 2025
@hagenw hagenw merged commit 3b21cc3 into main Jan 23, 2025
11 checks passed
@hagenw hagenw deleted the artifactory-update branch January 23, 2025 12:29
@hagenw hagenw mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant