Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to audfactory #106

Merged
merged 14 commits into from
Apr 27, 2023
Merged

Remove dependency to audfactory #106

merged 14 commits into from
Apr 27, 2023

Conversation

frankenjoe
Copy link
Collaborator

@frankenjoe frankenjoe commented Apr 26, 2023

Closes #50 #90

  • The dependency to audfactory is removed and a dependency to dohq-artifactory is set instead
  • The functions to authenticate and download / deploy an artifact are extracted from audfactory and modified accordingly
  • Authentication is done only once when the backend is created and re-used afterwards
  • The path of the config file can now be set via ARTIFACTORY_CONFIG_FILE

image

@frankenjoe frankenjoe requested a review from hagenw April 26, 2023 14:46
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #106 (584fe0f) into dev (14a568d) will not change coverage.
The diff coverage is 100.0%.

Impacted Files Coverage Δ
audbackend/core/artifactory.py 100.0% <100.0%> (ø)

@frankenjoe frankenjoe changed the title Remove dependency to audfactory WIP: Remove dependency to audfactory Apr 27, 2023
@frankenjoe frankenjoe changed the title WIP: Remove dependency to audfactory Remove dependency to audfactory Apr 27, 2023
Copy link
Member

@hagenw hagenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I think we made big progress regarding future proof with the Artifactory backend by no longer requiring audfactory and raising always the same error if there is an error happening on the backend

audbackend/core/artifactory.py Outdated Show resolved Hide resolved
tests/test_artifactory.py Outdated Show resolved Hide resolved
Co-authored-by: Hagen Wierstorf <[email protected]>
@hagenw hagenw merged commit 286a16d into dev Apr 27, 2023
@hagenw hagenw deleted the remove-audfactory branch April 27, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on audfactory
2 participants