Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cardio git-bisect-friendly #3

Open
msiebuhr opened this issue Jan 31, 2013 · 1 comment
Open

Make cardio git-bisect-friendly #3

msiebuhr opened this issue Jan 31, 2013 · 1 comment

Comments

@msiebuhr
Copy link
Contributor

It would be rather nice to execute something like the following:

git bisect start <bad> <good> -- cardio --check "css.countByColor.#eee > 1"

Then it would find the revision between good and bad here the check begins to fail (i.e. the color #eee drops below one).

papandreou added a commit that referenced this issue Jan 31, 2013
@papandreou
Copy link
Collaborator

Added experimental implementation in 0f271ac. Requires the check parameter to be valid JavaScript, so you need to use bracket notation for things like #eee and class.

cardio example/index.html --check 'html.countByAttributeName.href > 25' ; echo $?

Outputs 0, whereas

cardio example/index.html --check 'html.countByAttributeName.href > 23' ; echo $?

outputs 1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants