ADM-1003: [frontend][backend][docs]: re-calculate the lead time for changes for source control data in the report page #1601

zhou-yinyuan · 2024-09-11T03:10:44Z

Summary

re-calculate the lead time for changes for source control data in the report page.

Before

Description

In the report page, we didn't show the lead time for changes for source control data in the report page, and didn't show the data in the metrics and pipeline csv files.

After

Description

In the report page, we will show the lead time for changes for source control data in the report page, add two columns to show pr lead time for source control data in the pipeline csv file, and add lead time for changes to metrics data for source control data

Note

Null

* ADM-999 [frontend][backend]: fix the error path * ADM-999 [frontend][backend]: fix the test

…rce control data

…nges of source control in the report page

codacy-production · 2024-09-11T03:10:48Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.00%	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`5f11cba`)	9328	9328	100.00%
Head commit (`8c5165b`)	19140 (+9812)	19140 (+9812)	100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1601)	412	412	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

github-actions · 2024-09-11T03:10:58Z

Hi @zhou-yinyuan! 👋
Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

sonarqubecloud · 2024-09-11T03:14:15Z

Quality Gate passed for 'heartbeat-backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-09-11T03:15:43Z

Quality Gate passed for 'au-heartbeat-heartbeat-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

guzhongren

So biggger PR, please make it small in the future

guzhongren · 2024-09-25T13:30:00Z

backend/src/main/java/heartbeat/service/report/calculator/LeadTimeForChangesCalculator.java

+			return null;
+		}
+		int buildNumber = leadTimes.size();
+		// 过滤掉noPr的数据


remove comments

guzhongren · 2024-09-25T13:30:44Z

backend/src/main/java/heartbeat/service/source/github/GitHubService.java

+			.map(PullRequestInfo.PullRequestUser::getLogin)
+			.distinct()
+			.toList();
+		log.info("Successfully to get all crews, organization: {}, repo: {}, branch: {}, startTime: {}, endTime: {}",


guzhongren · 2024-09-25T13:31:03Z

backend/src/main/java/heartbeat/service/source/github/GitHubService.java

+			}
+		}
+		log.info(
+				"Successfully to filter pull request, startTime: {}, endTime: {}, should get next page pull request: {}",


guzhongren · 2024-09-25T13:31:37Z

backend/src/main/java/heartbeat/service/source/github/GitHubService.java

+										realToken)
+								.get(0);
+							log.info(
+									"Successfully to get first code commit, organization: {}, repo: {}, pull number: {}",


No to, please delete others

guzhongren · 2024-09-25T13:32:37Z

backend/src/test/java/heartbeat/service/pipeline/buildkite/CachePageServiceTest.java

+	@ParameterizedTest
+	@MethodSource("baseExceptionProvider")
+	void shouldThrowExceptionWhenFetchPageBranchInfoThrow4xx(BaseException e, int errorCode) {
+		String organization = "test-org";


Duplicated code

zhou-yinyuan and others added 18 commits September 11, 2024 10:42

ADM-1003 [backend]: feat: get lead time data for source control

b9a6eba

ADM-1003 [frontend]: fix: fix the next button in the metrics page

152a6a1

ADM-1003 [frontend]: fix: fix the request in the report page

3806501

ADM-1003 [backend]: test: fix backend test

a852969

ADM-1003 [backend]: feat: change the structure for repo data

c4974a8

ADM-999 [frontend][backend]: fix the error path (#1598)

ec5d3e8

* ADM-999 [frontend][backend]: fix the error path * ADM-999 [frontend][backend]: fix the test

ADM-1003 [backend]: feat: re-calculate lead time for changes with sou…

a6cfc2c

…rce control data

ADM-1003 [backend]: style: format

05f250a

ADM-1003 [backend]: feat: save source control data to file for share api

9e4b449

ADM-1003 [frontend]: feat: change the frontend content and style

fca4b53

ADM-1003 [backend]: feat: update metrics csv file and refactor

a99ac15

ADM-1003 [backend]: fix: fix crew bug when the crew is empty

513f77a

ADM-1003 [backend]: feat: update the pipeline csv file

67612fe

ADM-1003 [backend][frontend]: fix: fix sonar issues

f836a0c

ADM-1003 [frontend]: fix: fix comments

f350802

ADM-1003 [frontend]: fix: fix sonar issues

eb3e5a7

ADM-1003 [frontend]: test: fix e2e test

0d89cf5

ADM-1003 [frontend]: test: add e2e test content for lead time for cha…

8c5165b

…nges of source control in the report page

guzhongren approved these changes Sep 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADM-1003: [frontend][backend][docs]: re-calculate the lead time for changes for source control data in the report page #1601

ADM-1003: [frontend][backend][docs]: re-calculate the lead time for changes for source control data in the report page #1601

zhou-yinyuan commented Sep 11, 2024

codacy-production bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024

sonarqubecloud bot commented Sep 11, 2024

sonarqubecloud bot commented Sep 11, 2024

guzhongren left a comment

guzhongren Sep 25, 2024

guzhongren Sep 25, 2024

guzhongren Sep 25, 2024

guzhongren Sep 25, 2024

guzhongren Sep 25, 2024

ADM-1003: [frontend][backend][docs]: re-calculate the lead time for changes for source control data in the report page #1601

Are you sure you want to change the base?

ADM-1003: [frontend][backend][docs]: re-calculate the lead time for changes for source control data in the report page #1601

Conversation

zhou-yinyuan commented Sep 11, 2024

Summary

Before

After

Note

codacy-production bot commented Sep 11, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

github-actions bot commented Sep 11, 2024

sonarqubecloud bot commented Sep 11, 2024

Quality Gate passed for 'heartbeat-backend'

sonarqubecloud bot commented Sep 11, 2024

Quality Gate passed for 'au-heartbeat-heartbeat-frontend'

guzhongren left a comment

Choose a reason for hiding this comment

guzhongren Sep 25, 2024

Choose a reason for hiding this comment

guzhongren Sep 25, 2024

Choose a reason for hiding this comment

guzhongren Sep 25, 2024

Choose a reason for hiding this comment

guzhongren Sep 25, 2024

Choose a reason for hiding this comment

guzhongren Sep 25, 2024

Choose a reason for hiding this comment

codacy-production bot commented Sep 11, 2024 •

edited

Loading