Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adm-935 [frontend] change readme #1487

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Adm-935 [frontend] change readme #1487

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
677a597
ADM-935: [frontend] change frontend README
Mandy-Tang Jun 14, 2024
73f8187
ADM-935: [frontend] format readme
Mandy-Tang Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions frontend/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,14 @@ test.cy.ts:

## Page Responsibility

We need consider responsibility in our page. We consider three main breakpoints in out system, 390, 1280 and 1920.
Our minimum page size is 390, so that if the screen size is smaller than 390, the page will scroll Horizontally.
When the screen size is smaller than 1280, it shows the mobile view.
When the screen size is 1280 or larger than 1280, it shows the desktop view.
When the screen size is larger than 1920, the content size will no longer chang with the screen size, that means it will keep the same size with it in 1920.
We need consider responsibility in our page. We consider three main breakpoints in out system, 390, 1280 and 1920. For the screen size,

the breakpoints are set in theme.js file.
- if < 390, the page size will keep 390 and scrolls horizontally;
- if >= 390 and < 1280, it shows mobile view and the content size will change to fit viewport;
- if >= 1280 and <= 1920, it shows desktop view, the content size is 70% of the viewport but has a minimum size 1240 and a maximum size 1344.
- if > 1920, the content size will no longer change with the screen size, that means it will keep the same size with it in 1920. But the page header will still change to fit viewport.

the breakpoints are set in `theme.js` file.

```
breakpoints: {
Expand Down
Loading