Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM-794:[backend]fix: repair test to add sleep #1018

Merged
merged 8 commits into from
Feb 1, 2024
Merged

ADM-794:[backend]fix: repair test to add sleep #1018

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4023cfe
ADM-794:[backend]fix: add test for generate report
yulongcai Jan 30, 2024
7316696
ADM-794:[backend]fix: repair test for pipeline
yulongcai Jan 31, 2024
9b63d5f
ADM-794:[backend]fix: add test for pipeline
yulongcai Jan 31, 2024
65b2d4a
ADM-794:[backend]fix: refactor code
yulongcai Feb 1, 2024
387df3b
Merge branch 'main' into ADM-794
yulongcai Feb 1, 2024
5cb1dfc
ADM-794:[backend]fix: refactor for report service test
yulongcai Feb 1, 2024
2696ae6
ADM-794:[backend]fix: repair test to add sleep
yulongcai Feb 1, 2024
fd97098
Merge branch 'main' into ADM-794
yulongcai Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/src/test/java/heartbeat/service/report/ReportServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ void ShouldInitializeMetricsDataCompletedInHandlerWithPreOneWhenPreOneExisted()
}

@Test
void ShouldInitializeMetricsDataCompletedInHandlerWhenRequestMetricsExist() {
void ShouldInitializeMetricsDataCompletedInHandlerWhenRequestMetricsExist() throws InterruptedException {
MetricsDataCompleted expectMetricsDataResult = MetricsDataCompleted.builder()
.boardMetricsCompleted(false)
.pipelineMetricsCompleted(true)
Expand All @@ -124,6 +124,7 @@ void ShouldInitializeMetricsDataCompletedInHandlerWhenRequestMetricsExist() {
.thenReturn(MetricsDataCompleted.builder().pipelineMetricsCompleted(true).build());
doAnswer(invocation -> null).when(generateReporterService).generateBoardReport(request);

Thread.sleep(100);
reportService.generateReportByType(request, MetricType.BOARD);

verify(asyncMetricsDataHandler).putMetricsDataCompleted("csvTimeStamp", expectMetricsDataResult);
Expand Down
Loading