Skip to content

Commit

Permalink
ADM-983 [frontend]: rename the dora chart
Browse files Browse the repository at this point in the history
  • Loading branch information
zhou-yinyuan committed Jul 29, 2024
1 parent 6093183 commit 639a0a2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
14 changes: 7 additions & 7 deletions frontend/src/constants/resources.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ export enum ChartType {
Classification = 'Classification',
LeadTimeForChanges = 'Lead Time For Changes',
DeploymentFrequency = 'Deployment Frequency',
DevChangeFailureRate = 'Dev Change Failure Rate',
DevMeanTimeToRecovery = 'Dev Mean Time To Recovery',
PipelineChangeFailureRate = 'Pipeline Change Failure Rate',
PipelineMeanTimeToRecovery = 'Pipeline Mean Time To Recovery',
}

export enum TrendIcon {
Expand All @@ -124,9 +124,9 @@ export const CHART_TREND_TIP = {
[ChartType.CycleTimeAllocation]: 'Total development time/Total cycle time',
[ChartType.Rework]: 'Total rework times',
[ChartType.LeadTimeForChanges]: 'Lead Time',
[ChartType.DeploymentFrequency]: 'Mean Time To Recovery',
[ChartType.DevChangeFailureRate]: 'Dev Change Failure Rate',
[ChartType.DevMeanTimeToRecovery]: 'Dev Mean Time To Recovery',
[ChartType.DeploymentFrequency]: 'Deployment Frequency',
[ChartType.PipelineChangeFailureRate]: 'Pipeline Change Failure Rate',
[ChartType.PipelineMeanTimeToRecovery]: 'Pipeline Mean Time To Recovery',
[ChartType.Classification]: 'Classification',
};

Expand All @@ -139,8 +139,8 @@ export const DOWN_TREND_IS_BETTER: ChartType[] = [
ChartType.Rework,
ChartType.CycleTime,
ChartType.LeadTimeForChanges,
ChartType.DevMeanTimeToRecovery,
ChartType.DevChangeFailureRate,
ChartType.PipelineMeanTimeToRecovery,
ChartType.PipelineChangeFailureRate,
];

export enum MetricsSubtitle {
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/containers/ReportStep/DoraMetricsChart/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ function extractedChangeFailureRateData(
}
return value || 0;
});
const trendInfo = calculateTrendInfo(value, allDateRanges, ChartType.DevChangeFailureRate);
const trendInfo = calculateTrendInfo(value, allDateRanges, ChartType.PipelineChangeFailureRate);
return {
legend: RequiredData.PipelineChangeFailureRate,
xAxis: allDateRanges,
Expand Down Expand Up @@ -214,7 +214,7 @@ function extractedMeanTimeToRecoveryDataData(
if (!totalItem) return 0;
return Number(totalItem.valueList[0].value) || 0;
});
const trendInfo = calculateTrendInfo(value, allDateRanges, ChartType.DevMeanTimeToRecovery);
const trendInfo = calculateTrendInfo(value, allDateRanges, ChartType.PipelineMeanTimeToRecovery);
return {
legend: RequiredData.PipelineMeanTimeToRecovery,
xAxis: allDateRanges,
Expand Down

0 comments on commit 639a0a2

Please sign in to comment.