ADM-1009 [frontend]: fix the 4xx error

au-heartbeat · Sep 18, 2024 · 53cdc50 · 53cdc50
1 parent 2a79f8c
commit 53cdc50
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/frontend/src/hooks/useGetMetricsStepsEffect.ts b/frontend/src/hooks/useGetMetricsStepsEffect.ts
@@ -88,7 +88,8 @@ export const useGetMetricsStepsEffect = (): useGetMetricsStepsEffectInterface =>
       setStepFailedStatus(MetricsDataFailStatus.NotFailed);
     } else if (hasRejected && hasFulfilled) {
       const rejectedStep = allStepsRes.find((stepInfo) => stepInfo.status === REJECTED);
-      if ((rejectedStep as PromiseRejectedResult).reason.code == 400) {
+      const code = (rejectedStep as PromiseRejectedResult).reason.code;
+      if (code === 400 || code === 401 || code === 403 || code === 404) {
         setStepFailedStatus(MetricsDataFailStatus.PartialFailed4xx);
       } else {
         setStepFailedStatus(MetricsDataFailStatus.PartialFailedTimeout);

diff --git a/frontend/src/hooks/useGetSourceControlConfigurationBranchEffect.tsx b/frontend/src/hooks/useGetSourceControlConfigurationBranchEffect.tsx
@@ -78,7 +78,7 @@ export const useGetSourceControlConfigurationBranchEffect = (): IUseGetSourceCon
             }),
           ),
         );
-        if (response.code === 400) {
+        if (response.code === 400 || response.code === 401 || response.code === 403 || response.code === 404) {
           setStepFailedStatus(MetricsDataFailStatus.AllFailed4xx);
         } else if (response.code === 200) {
           setIsGetBranch(true);

diff --git a/frontend/src/hooks/useGetSourceControlConfigurationCrewEffect.tsx b/frontend/src/hooks/useGetSourceControlConfigurationCrewEffect.tsx
@@ -79,7 +79,8 @@ export const useGetSourceControlConfigurationCrewEffect = (): IUseGetSourceContr
       setStepFailedStatus(MetricsDataFailStatus.NotFailed);
     } else if (hasRejected && hasFulfilled) {
       const rejectedStep = allCrewsRes.find((crewInfo) => crewInfo.status === REJECTED);
-      if ((rejectedStep as PromiseRejectedResult).reason.code == 400) {
+      const code = (rejectedStep as PromiseRejectedResult).reason.code;
+      if (code === 400 || code === 401 || code === 403 || code === 404) {
         setStepFailedStatus(MetricsDataFailStatus.PartialFailed4xx);
       } else {
         setStepFailedStatus(MetricsDataFailStatus.PartialFailedTimeout);

diff --git a/frontend/src/hooks/useGetSourceControlConfigurationRepoEffect.tsx b/frontend/src/hooks/useGetSourceControlConfigurationRepoEffect.tsx
@@ -74,7 +74,8 @@ export const useGetSourceControlConfigurationRepoEffect = (): IUseGetSourceContr
       setStepFailedStatus(MetricsDataFailStatus.NotFailed);
     } else if (hasRejected && hasFulfilled) {
       const rejectedStep = allRepoRes.find((repoInfo) => repoInfo.status === REJECTED);
-      if ((rejectedStep as PromiseRejectedResult).reason.code == 400) {
+      const code = (rejectedStep as PromiseRejectedResult).reason.code;
+      if (code === 400 || code === 401 || code === 403 || code === 404) {
         setStepFailedStatus(MetricsDataFailStatus.PartialFailed4xx);
       } else {
         setStepFailedStatus(MetricsDataFailStatus.PartialFailedTimeout);