ADM-944: [frontend] feat: fix sonar isuue

au-heartbeat · May 29, 2024 · 525e167 · 525e167
1 parent 1423993
commit 525e167
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/frontend/src/containers/ReportStep/ChartAndTitleWrapper/index.tsx b/frontend/src/containers/ReportStep/ChartAndTitleWrapper/index.tsx
@@ -43,18 +43,16 @@ const ChartAndTitleWrapper = forwardRef(
         return INCREASE;
       } else if (trendInfo.trendNumber < 0) {
         return DECREASE;
+      } else if (UP_TREND_IS_BETTER.includes(trendInfo.type)){
+        return INCREASE;
       } else {
-        if (UP_TREND_IS_BETTER.includes(trendInfo.type)) {
-          return INCREASE;
-        } else {
-          return DECREASE;
-        }
+        return DECREASE;
       }
     };
     const tipContent = (
       <StyledToolTipContent>
         <p>{`The rate of ${trendDescribe()} for ${CHART_TREND_TIP[trendInfo.type]}: `}</p>
-        {trendInfo.dateRangeList?.map((dateRange, index) => <p key={index}>{dateRange}</p>)}
+        {trendInfo.dateRangeList?.map((dateRange) => <p key={dateRange}>{dateRange}</p>)}
       </StyledToolTipContent>
     );
 

diff --git a/frontend/src/containers/ReportStep/DoraMetricsChart/index.tsx b/frontend/src/containers/ReportStep/DoraMetricsChart/index.tsx
@@ -33,7 +33,7 @@ function extractedStackedBarData(allDateRanges: string[], mappedData: ReportResp
     .slice(0, 2);
   const extractedValues = mappedData?.map((data) =>
     data.leadTimeForChangesList?.[0].valuesList.map((item) => {
-      return Number(item.value!);
+      return Number(item.value);
     }),
   );
   const prLeadTimeValues = extractedValues?.map((value) => value![0]);

diff --git a/frontend/src/utils/util.ts b/frontend/src/utils/util.ts
@@ -219,7 +219,7 @@ export const xAxisLabelDateFormatter = (dateRange: string) => {
 export const getTrendInfo = (trendNumber: number, dateRangeList: string[], type: CHART_TYPE) => {
   const result: ITrendInfo = {
     trendNumber: trendNumber,
-    dateRangeList: dateRangeList as string[],
+    dateRangeList: dateRangeList,
     type,
   } as ITrendInfo;
 
@@ -254,7 +254,7 @@ export const calculateTrendInfo = (
   const beforeLatestValidIndex = dataList.findLastIndex((data, index) => data && index !== latestValidIndex);
 
   const trendNumber =
-    (dataList[latestValidIndex]! - dataList[beforeLatestValidIndex]!) / dataList[beforeLatestValidIndex]!;
+    (dataList[latestValidIndex] - dataList[beforeLatestValidIndex]) / dataList[beforeLatestValidIndex];
   const validDateRangeList: string[] = [];
   validDateRangeList.push(dateRangeList[latestValidIndex], dateRangeList[beforeLatestValidIndex]);