Skip to content

Commit

Permalink
ADM-1005 [frontend][backend]: fix e2e test in the buildkite and github (
Browse files Browse the repository at this point in the history
#1614)

* ADM-1005 [frontend]: fix the bug when pipeline settings exist in the redux but user select Other in the pipeline configuration

* ADM-1005 [frontend]: fix test coverage

* ADM-1005 [frontend][backend]: update the pipeline csv file

* ADM-1005 [frontend][backend]: fix test

* ADM-1005 [frontend]: fix e2e test

* ADM-1005 [frontend]: add a test for with pipeline and source control configuration

* ADM-1005 [frontend]: format

* ADM-1005 [frontend]: format

* ADM-1005 [frontend][backend]: fix e2e test in the buildkite and github
  • Loading branch information
zhou-yinyuan authored Sep 27, 2024
1 parent 48fb4b3 commit 2a2123f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/build-and-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@ jobs:
E2E_TOKEN_BUILD_KITE: ${{ secrets.E2E_TOKEN_BUILD_KITE }}
E2E_TOKEN_GITHUB: ${{ secrets.E2E_TOKEN_GITHUB }}
E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE: ${{ secrets.E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE }}
E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL: ${{ secrets.E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL }}
E2E_PROJECT: "Google Chrome"
shell: bash {0}
run: ./ops/check.sh e2e
Expand Down Expand Up @@ -505,6 +506,7 @@ jobs:
E2E_TOKEN_BUILD_KITE: ${{ secrets.E2E_TOKEN_BUILD_KITE }}
E2E_TOKEN_GITHUB: ${{ secrets.E2E_TOKEN_GITHUB }}
E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE: ${{ secrets.E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE }}
E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL: ${{ secrets.E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL }}
E2E_PROJECT: ${{ env.E2E_PLATFORM }}
shell: bash {0}
run: ./ops/check.sh e2e
Expand Down Expand Up @@ -535,6 +537,7 @@ jobs:
E2E_TOKEN_BUILD_KITE: ${{ secrets.E2E_TOKEN_BUILD_KITE }}
E2E_TOKEN_GITHUB: ${{ secrets.E2E_TOKEN_GITHUB }}
E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE: ${{ secrets.E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE }}
E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL: ${{ secrets.E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL }}
E2E_PROJECT: ${{ env.E2E_PLATFORM }}
shell: bash {0}
run: ./ops/check.sh e2e
Expand Down Expand Up @@ -565,6 +568,7 @@ jobs:
E2E_TOKEN_BUILD_KITE: ${{ secrets.E2E_TOKEN_BUILD_KITE }}
E2E_TOKEN_GITHUB: ${{ secrets.E2E_TOKEN_GITHUB }}
E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE: ${{ secrets.E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE }}
E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL: ${{ secrets.E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL }}
E2E_PROJECT: ${{ env.E2E_PLATFORM }}
shell: bash {0}
run: ./ops/check.sh e2e
Expand Down Expand Up @@ -594,6 +598,7 @@ jobs:
E2E_TOKEN_BUILD_KITE: ${{ secrets.E2E_TOKEN_BUILD_KITE }}
E2E_TOKEN_GITHUB: ${{ secrets.E2E_TOKEN_GITHUB }}
E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE: ${{ secrets.E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE }}
E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL: ${{ secrets.E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL }}
E2E_PROJECT: ${{ env.E2E_PLATFORM }}
shell: bash {0}
run: ./ops/check.sh e2e
Expand Down
1 change: 1 addition & 0 deletions ops/check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ e2e_container_check() {
-e "E2E_TOKEN_GITHUB=${E2E_TOKEN_GITHUB:-}" \
-e "CI=${CI:-}" \
-e "E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE=${E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE:-}" \
-e "E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL=${E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL:-}" \
heartbeat_e2e:latest \
pnpm run e2e:major-ci
result=$?
Expand Down

0 comments on commit 2a2123f

Please sign in to comment.