ADM-652[frontend][backend] update error message

au-heartbeat · Jan 11, 2024 · 0219d5c · 0219d5c
1 parent e904f96
commit 0219d5c
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/docs/src/content/docs/en/designs/refinement-on-generate-report.mdx b/docs/src/content/docs/en/designs/refinement-on-generate-report.mdx
@@ -153,7 +153,7 @@ Exception Table
   <tr>
     <td rowspan="3">404</td>
     <td>Failed to get BuildKite info_status: 404...</td>
-    <td rowspan="3">404 Not Found</td>
+    <td rowspan="3">Not found</td>
   </tr>
   <tr>
     <td>Failed to get GitHub info_status: 404...</td>
@@ -164,7 +164,7 @@ Exception Table
   <tr>
     <td rowspan="3">500</td>
     <td>Report time expires</td>
-    <td rowspan="3">Generate report failed</td>
+    <td rowspan="3">Failed to generate report</td>
   </tr>
   <tr>
     <td>Failed to write report file</td>
@@ -175,7 +175,7 @@ Exception Table
   <tr>
     <td rowspan="3">503</td>
     <td>Failed to get BuildKite info_status: 503...</td>
-    <td rowspan="3">Service Unavailable</td>
+    <td rowspan="3">Service unavailable</td>
   </tr>
   <tr>
     <td>Failed to get GitHub info_status: 503...</td>
@@ -208,7 +208,7 @@ group async process board related metrics
     activate Jira
     Jira --> Backend: Jira raw 
     deactivate Jira
-    Backend -> Backend: calculate metrics for velocity, cicle time and classification
+    Backend -> Backend: calculate metrics for velocity, cycle time and classification
     Backend -> Backend: generate board report csv
     deactivate Backend
     note left

diff --git a/frontend/__tests__/src/client/CSVClient.test.ts b/frontend/__tests__/src/client/CSVClient.test.ts
@@ -30,7 +30,11 @@ describe('verify export csv', () => {
   });
 
   it('should throw error when export csv request status 500', async () => {
-    server.use(rest.get(MOCK_EXPORT_CSV_URL, (req, res, ctx) => res(ctx.status(HttpStatusCode.InternalServerError))));
+    server.use(
+      rest.get(MOCK_EXPORT_CSV_URL, (req, res, ctx) =>
+        res(ctx.status(HttpStatusCode.InternalServerError, VERIFY_ERROR_MESSAGE.INTERNAL_SERVER_ERROR))
+      )
+    );
 
     await expect(async () => {
       await csvClient.exportCSVData(MOCK_EXPORT_CSV_REQUEST_PARAMS);

diff --git a/frontend/__tests__/src/fixtures.ts b/frontend/__tests__/src/fixtures.ts
@@ -105,8 +105,8 @@ export const VERSION_RESPONSE = {
 export enum VERIFY_ERROR_MESSAGE {
   BAD_REQUEST = 'Please reconfirm the input',
   UNAUTHORIZED = 'Token is incorrect',
-  INTERNAL_SERVER_ERROR = 'Internal Server Error',
-  NOT_FOUND = '404 Not Found',
+  INTERNAL_SERVER_ERROR = 'Internal server error',
+  NOT_FOUND = 'Not found',
   PERMISSION_DENIED = 'Permission denied',
   REQUEST_TIMEOUT = 'Request Timeout',
   UNKNOWN = 'Unknown',
@@ -692,7 +692,7 @@ export const CLASSIFICATION_WARNING_MESSAGE = `Some classifications in import da
 export const HOME_VERIFY_IMPORT_WARNING_MESSAGE =
   'The content of the imported JSON file is empty. Please confirm carefully';
 
-export const INTERNAL_SERVER_ERROR_MESSAGE = 'Internal Server Error';
+export const INTERNAL_SERVER_ERROR_MESSAGE = 'Internal server error';
 
 export const BASE_PAGE_ROUTE = '/';
 

diff --git a/frontend/cypress/pages/metrics/metrics.ts b/frontend/cypress/pages/metrics/metrics.ts
@@ -76,7 +76,7 @@ export class Metrics {
   }
 
   get buildKiteStepNotFoundTips() {
-    return cy.contains('BuildKite get steps failed: 404 Not Found');
+    return cy.contains('BuildKite get steps failed: Not found');
   }
 
   get pipelineRemoveButton() {