Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add healthcheck using netcat and sed #2451

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add healthcheck using netcat and sed #2451

wants to merge 3 commits into from

Conversation

mortee
Copy link

@mortee mortee commented Nov 19, 2024

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@mateuscomh
Copy link
Contributor

@mortee suggestion: great idea implement heathcheck. But to optimize the image size and reduce unnecessary dependencies, consider replacing curl and jq with netcat (nc) in the health check. This change will minimize the number of packages installed in the final runtime image and improve efficiency.

@mortee mortee changed the title add healthcheck using curl and jq add healthcheck using netcat and sed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortee @mateuscomh