-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CTRL+[
binding as <Esc>
alias
#1787
Conversation
in Vim/Neovim there is alias for `<Esc>` mapping -- `<C-[>`. it is useful if your `<Esc>` key is hard to hit on your keyboard. for reference: https://vimhelp.org/insert.txt.html#i_CTRL-%5B https://neovim.io/doc/user/insert.html#i_CTRL-%5B
2 questions:
|
I actually always use C-[ to send ESC because I have difficulty in pressing ESC. Only when I use the keyboard of a laptop machine, without breaking the home position, I can reach ESC with my little finger. On all the keyboards of the full size, it's impossible for me to reach the ESC key.
This PR is only relevant when an advanced keyboard protocol is enabled. If the advanced keyboard protocol is enabled, it should work better in terminal multiplexers because the protocol is free from the heuristic and obscure distinction of Meta modifier vs ESC, which the terminal multiplexer needs to process. (But, I'm not sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the exactly same reasons as #1720, I agree to have this binding.
Isn't there already |
ESC and C-[ are equivalent in the traditional terminal protocol, and we should assign the same functionality to both even in the advanced keyboard protocol unless we would drop the support for the traditional terminal protocols. Given C-c and C-g already exit the Atuin session, another option would be to remove the keybinding to ESC, but that doesn't seem useful to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in Vim/Neovim there is alias for
<Esc>
mapping --<C-[>
. it is useful if your<Esc>
key is hard to hit on your keyboard.for reference:
Checks