Fix/1207 deleted entries shown in interactive search #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deicon
commented
Sep 29, 2023
deicon
commented
- Deleted entries have not been excluded from the db queries
- Using deleted_at field to include/exclude deleted items
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
deicon
commented
Sep 29, 2023
ellie
reviewed
Sep 29, 2023
auto-merge was automatically disabled
September 29, 2023 15:58
Head branch was pushed to by a user without write access
|
@ellie reverted your auto merge as cargo fmt was missing. my bad |
|
Anything missing still here ? |
|
Just the merge conflicts and I'm happy to merge! Thank you for the work |
auto-merge was automatically disabled
October 4, 2023 18:01
Head branch was pushed to by a user without write access
|
@ellie Alright. Missed the print0 PR as it came later. I added the missing documentation of the print0 parameter as well after fixing the conflict |
ellie
previously approved these changes
Oct 4, 2023
auto-merge was automatically disabled
October 4, 2023 18:05
Head branch was pushed to by a user without write access
|
@ellie I keep forgetting cargo fmt. need to update my config |
ellie
approved these changes
Oct 4, 2023
deicon
deleted the
fix/1207_Deleted_Entries_shown_in_interactive_search
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.